TIMEOUT: 17:00 PST May 3
https://glassfish.dev.java.net/issues/show_bug.cgi?id=2965
km105526: com/sun/enterprise/admin/servermgmt/SMFService.java:543:543
DE: com.sun.enterprise.admin.servermgmt.SMFService.fileContainsToken
(String,String,java.util.Map) might ignore java.lang.Exception (H)
dpatil: com/sun/enterprise/admin/servermgmt/FileValidator.java:44:44
MS:
com.sun.enterprise.admin.servermgmt.FileValidator.validConstraints
isn't final but should be (H)
Index: admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/
FileValidator.java
===================================================================
RCS file: /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/
admin/servermgmt/FileValidator.java,v
retrieving revision 1.3
diff -w -u -r1.3 FileValidator.java
--- admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/
FileValidator.java 25 Dec 2005 03:44:01 -0000 1.3
+++ admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/
FileValidator.java 3 May 2007 18:54:11 -0000
@@ -35,13 +35,14 @@
* read, write & execute permissions,
* whether the file is a directory or a file
* </ul>
+ * <b>NOT THREAD SAFE</b>
*/
public class FileValidator extends Validator
{
/**
* The valid constraint set.
*/
- public static String validConstraints = "drwx";
+ public static final String validConstraints = "drwx";
/**
* i18n strings manager object
Index: admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/
SMFService.java
===================================================================
RCS file: /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/
admin/servermgmt/SMFService.java,v
retrieving revision 1.13
diff -w -u -r1.13 SMFService.java
--- admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/
SMFService.java 2 May 2007 06:35:02 -0000 1.13
+++ admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/
SMFService.java 3 May 2007 18:54:11 -0000
@@ -52,7 +52,7 @@
* @see #isConfigValid
* @see SMFServiceHandler
*/
-public class SMFService implements Service {
+public final class SMFService implements Service {
public static final String DATE_CREATED_TN =
"DATE_CREATED";
public static final String SERVICE_NAME_TN = "NAME";
@@ -537,12 +537,21 @@
throw new RuntimeException(e);
}
finally {
- if (bis != null)
+ if (bis != null) {
try {
bis.close();
- } catch(Exception ee) {}
+ } catch(Exception ee) {
+ IGNORE_EXCEPTION(ee);
}
}
+ }
+ }
+
+
+ private static void IGNORE_EXCEPTION(final Exception e ) {
+ // ignore
+ }
+
private boolean serviceNameExists(final String sn) {
boolean exists = false;
try {