admin@glassfish.java.net

Re: Code Review: Timeout today in another one hour :)

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Tue, 10 Apr 2007 18:30:18 -0700

Here's a reference:
http://java.sun.com/docs/books/jls/second_edition/html/typesValues.doc.html

"A /blank final/ is a final variable whose declaration lacks an
initializer. Once a |final| variable has been assigned, it always
contains the same value."

It does not say anthing about that it has to be initialized in
constructor or static block.



kedar wrote:

> Actually, I had similar doubts, but interestingly, it compiles :)
>
> I think I should read JLS, but I am saving it for later.
> What's the rule for blank finals? Can someone refresh me here?
> I thought blank finals can be initialized only in constructors
> or static blocks. Apparently not ...
>
> Kedar
>
> Lloyd L Chambers wrote:
>
>> I can't see how this code even compiles:
>>
>> + final ConfigContext configCtxt;
>> + final ConfigContext configCtxt;
>> + if (this.getRefreshConfigContext()) //refresh, hence cache =
>> false, new CC is returned;
>> + configCtxt =
>> ConfigFactory.createConfigContext(domainXMLLocation, true, false,
>> false);
>> + else //use cached config context
>> + configCtxt =
>> ConfigFactory.createConfigContext(domainXMLLocation, true, false, true);
>>
>> On Apr 10, 2007, at 5:18 PM, kedar wrote:
>>
>>> Hello folks,
>>>
>>> Byron and I have fixed a nasty bug in the cluster environment.
>>> There are bunch of bugs that are filed in this regard and the
>>> most prominent one is: 6514847 on Sun's database.
>>>
>>> Please review the attached diff's.
>>>
>>> Some background: Since node-agent starts the instances in process,
>>> it has to make sure that it does not use a cached version of the config
>>> context (a cached object referring to domain.xml). At the same time,
>>> if a part of code (start-domain) is sure that it is using the right
>>> config
>>> context, so that there is no duplicate parsing effort, then that
>>> part of
>>> code should let Launcher know it.
>>>
>>> I have tested most of the cases.
>>>
>>> Thanks,
>>> Kedar
>>> <diff.txt>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>