Re: CODE REVIEW (trivial), FindBugs, com.sun.enterprise.tools.util.JWhich

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

From: kedar <Kedar.Mhaswade_at_Sun.COM>
Date: Tue, 10 Apr 2007 11:14:58 -0700

Go ahead.

Lloyd L Chambers wrote:
> FindBugs was complaining of a dead store.
>
> RCS file:
> /cvs/glassfish/tools/src/java/com/sun/enterprise/tools/common/util/JWhich.java,v
>
> retrieving revision 1.3
> diff -r1.3 JWhich.java
> 48,49d47
> <
> < JWhich jwhich;
> 59c57
> < jwhich = new JWhich(args[2], args[1]);
> ---
> > new JWhich(args[2], args[1]);
> 62c60
> < jwhich = new JWhich(args[0]);
> ---
> > new JWhich(args[0]);
> 67c65
> < public JWhich(String classname, String classpathArg)
> ---
> > public JWhich(String classname, String classpathArgIn)
> 69c67
> < this.classpathArg = classpathArg;
> ---
> > classpathArg = classpathArgIn;
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>