admin@glassfish.java.net

Re: CODE REVIEW: com.sun.appserv.management.j2ee.WebModule (easy)

From: Byron Nevins <Byron.Nevins_at_Sun.COM>
Date: Mon, 23 Apr 2007 20:28:59 -0700

Reviewed! Go with throttle up...


Lloyd L Chambers wrote:

> Thanks...though in this case it's just two methods being removed from
> an interface, the reason for which is described in the bug...
>
> On Apr 23, 2007, at 4:16 PM, Byron Nevins wrote:
>
>> There's no context. Here is what I'd do:
>>
>> in the /glassfish/appserv-api directory -->
>>
>> run cvs diff -u > diffs.txt
>> edit commit.txt with the summary of changes
>> jar cvfM 282.zip src/java/com/sun/appserv/management/j2ee/
>> WebModule.java diffs.txt commit.txt
>>
>> The zip file has everything a reviewer needs...
>>
>> Lloyd L Chambers wrote:
>>
>>> TIMEOUT: noon on 4/24/07
>>>
>>> Addresses the following issue:
>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=282
>>>
>>> RCS file: /cvs/glassfish/appserv-api/src/java/com/sun/appserv/
>>> management/j2ee/WebModule.java,v
>>> retrieving revision 1.1
>>> diff -r1.1 WebModule.java
>>> 79,87d78
>>> < Time interval in ms between cache refeshes
>>> < */
>>> < public int getCacheTTL();
>>> < /**
>>> < Time interval in ms between cache refeshes
>>> < */
>>> < public void setCacheTTL( final int value );
>>> <
>>> < /**
>>> 187,191d177
>>> < Type of the modeled resource. Can be set only once
>>> < */
>>> < public String getModelerType();
>>> <
>>> < /**
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>