Fwd: CODE REVIEW: bug #1721 "thread-unsafe double-null-check idiom in com.sun.enterprise.admin.monitor.callflow.*"
Begin forwarded message:
> From: Lloyd Chambers <lloyd.chambers_at_mac.com>
> Date: December 11, 2006 11:41:30 AM PST
> To: dev_at_glassfish.dev.java.net
> Subject: CODE REVIEW: bug #1721 "thread-unsafe double-null-check
> idiom in com.sun.enterprise.admin.monitor.callflow.*"
>
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=1721
>
>
> cvs server: Diffing monitor/src/java/com/sun/enterprise/admin/
> monitor/callflow
> Index: monitor/src/java/com/sun/enterprise/admin/monitor/callflow/
> DbAccessObjectImpl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/
> admin/monitor/callflow/DbAccessObjectImpl.java,v
> retrieving revision 1.17
> diff -r1.17 DbAccessObjectImpl.java
> 164c164
> < public static DbAccessObject getInstance() {
> ---
> > public static synchronized DbAccessObject getInstance() {
> Index: monitor/src/java/com/sun/enterprise/admin/monitor/callflow/
> EndTimeAccessObjectImpl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/
> admin/monitor/callflow/EndTimeAccessObjectImpl.java,v
> retrieving revision 1.8
> diff -r1.8 EndTimeAccessObjectImpl.java
> 63c63
> < public static TableAccessObject getInstance() {
> ---
> > public static synchronized TableAccessObject getInstance() {
> Index: monitor/src/java/com/sun/enterprise/admin/monitor/callflow/
> MethodEndAccessObjectImpl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/
> admin/monitor/callflow/MethodEndAccessObjectImpl.java,v
> retrieving revision 1.10
> diff -r1.10 MethodEndAccessObjectImpl.java
> 75c75
> < public static TableAccessObject getInstance() {
> ---
> > public static synchronized TableAccessObject getInstance() {
> Index: monitor/src/java/com/sun/enterprise/admin/monitor/callflow/
> MethodStartAccessObjectImpl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/
> admin/monitor/callflow/MethodStartAccessObjectImpl.java,v
> retrieving revision 1.11
> diff -r1.11 MethodStartAccessObjectImpl.java
> 71c71
> < public static TableAccessObject getInstance() {
> ---
> > public static synchronized TableAccessObject getInstance() {
> Index: monitor/src/java/com/sun/enterprise/admin/monitor/callflow/
> RequestStartAccessObjectImpl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/
> admin/monitor/callflow/RequestStartAccessObjectImpl.java,v
> retrieving revision 1.11
> diff -r1.11 RequestStartAccessObjectImpl.java
> 90c90
> < public static TableAccessObject getInstance() {
> ---
> > public static synchronized TableAccessObject getInstance() {
> Index: monitor/src/java/com/sun/enterprise/admin/monitor/callflow/
> StartTimeAccessObjectImpl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/
> admin/monitor/callflow/StartTimeAccessObjectImpl.java,v
> retrieving revision 1.8
> diff -r1.8 StartTimeAccessObjectImpl.java
> 63c63
> < public static TableAccessObject getInstance() {
> ---
> > public static synchronized TableAccessObject getInstance() {
> cvs server: Diffing monitor/src/java
>
>