Do we really want to spend time doing a code review of changes that
involve inserting the keyword 'final'?
A build is sufficient to establish correctness, since it is a compile-
time change.
I think our process ought to have some deference to worthwhile uses
of developer time.
Lloyd
Begin forwarded message:
> From: Lloyd L Chambers <lloyd.chambers_at_sun.com>
> Date: December 11, 2006 3:13:36 PM PST
> To: admin_at_glassfish.dev.java.net
> Subject: CODE REVIEW: "FIND BUGS: fix non-final variables in
> J2EEDeployedObjectMdl, WebServiceEndpointMdl"
>
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=1723
>
>
> Index: src/java/com/sun/enterprise/management/model/
> J2EEDeployedObjectMdl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/mbeans/src/java/com/sun/enterprise/
> management/model/J2EEDeployedObjectMdl.java,v
> retrieving revision 1.5
> diff -r1.5 J2EEDeployedObjectMdl.java
> 33,37c33,37
> < public static int STARTING_STATE = 0;
> < public static int RUNNING_STATE = 1;
> < public static int STOPPING_STATE = 2;
> < public static int STOPPED_STATE = 3;
> < public static int FAILED_STATE = 4;
> ---
> > public static final int STARTING_STATE = 0;
> > public static final int RUNNING_STATE = 1;
> > public static final int STOPPING_STATE = 2;
> > public static final int STOPPED_STATE = 3;
> > public static final int FAILED_STATE = 4;
> 39,41c39,41
> < private J2EEModuleCallBack module;
> < private int state = this.RUNNING_STATE;
> < private long startTime = System.currentTimeMillis();
> ---
> > private final J2EEModuleCallBack module;
> > private volatile int state = this.RUNNING_STATE;
> > private volatile long startTime = System.currentTimeMillis();
> Index: src/java/com/sun/enterprise/management/model/
> WebServiceEndpointMdl.java
> ===================================================================
> RCS file: /cvs/glassfish/admin/mbeans/src/java/com/sun/enterprise/
> management/model/WebServiceEndpointMdl.java,v
> retrieving revision 1.10
> diff -r1.10 WebServiceEndpointMdl.java
> 44,46c44,46
> < private static String MANAGED_OBJECT_TYPE =
> "WebServiceEndpoint";
> < protected static String WEB_MBEAN = "ServletWebServiceEndpoint";
> < protected static String EJB_MBEAN = "EJBWebServiceEndpoint";
> ---
> > private static final String MANAGED_OBJECT_TYPE =
> "WebServiceEndpoint";
> > protected static final String WEB_MBEAN =
> "ServletWebServiceEndpoint";
> > protected static final String EJB_MBEAN =
> "EJBWebServiceEndpoint";
> 48,54c48,54
> < private String moduleName = null;
> < private String registrationName = null;
> < private String applicationName = null;
> < private String epName = null;
> < private boolean isEjb = false;
> < private boolean isStandAlone = false;
> < private String mbeanName = null;
> ---
> > private final String moduleName;
> > private final String registrationName;
> > private final String applicationName;
> > private final String epName;
> > private final boolean isEjb;
> > private final boolean isStandAlone;
> > private final String mbeanName;
>