admin@glassfish.java.net

Re: [code review] including jbi ant task definitions in default taskdefs set

From: srinivasan chikkala <Srinivasan.Chikkala_at_Sun.COM>
Date: Fri, 03 Nov 2006 12:04:19 -0800

FYI. Jane Young already reviewed this code and approved it.

Srinivasan Chikkala wrote:

> I have changed defaults.properties and the antlib.xml in
> glassfish\appserv-commons\src\java\org\apache\tools\ant\taskdefs to
> include the jbi ant tasks definitions for default inclusion of the jbi
> task definitions in user ant script when using asant. The classes
> corresponding to these tasks are already included in asant classpath
> and are at %AS_INSTALL%\jbi\lib\jbi-ant-tasks.jar
>
>------------------------------------------------------------------------
>
>? jbi-taskdefs-changes-diff.txt
>Index: apache/tools/ant/taskdefs/antlib.xml
>===================================================================
>RCS file: /cvs/glassfish/appserv-commons/src/java/org/apache/tools/ant/taskdefs/antlib.xml,v
>retrieving revision 1.3
>diff -u -r1.3 antlib.xml
>--- apache/tools/ant/taskdefs/antlib.xml 25 Dec 2005 04:12:43 -0000 1.3
>+++ apache/tools/ant/taskdefs/antlib.xml 2 Nov 2006 21:31:06 -0000
>@@ -32,4 +32,28 @@
> <taskdef name="sun-appserv-input" classname="org.apache.tools.ant.taskdefs.Input"/>
> <taskdef name="sun-appserv-jspc" classname="org.apache.tools.ant.taskdefs.optional.sun.appserv.SunJspc"/>
> <taskdef name="sun-appserv-update" classname="org.apache.tools.ant.taskdefs.optional.sun.appserv.UpdateTask"/>
>+
>+ <!-- BEGIN - Jbi Ant Task definitions -->
>+ <!-- jbi component tasks definitions -->
>+ <taskdef name="jbi-install-component" classname="com.sun.jbi.ui.ant.JbiInstallComponentTask"/>
>+ <taskdef name="jbi-uninstall-component" classname="com.sun.jbi.ui.ant.JbiUninstallComponentTask"/>
>+ <taskdef name="jbi-start-component" classname="com.sun.jbi.ui.ant.JbiStartComponentTask"/>
>+ <taskdef name="jbi-stop-component" classname="com.sun.jbi.ui.ant.JbiStopComponentTask"/>
>+ <taskdef name="jbi-shut-down-component" classname="com.sun.jbi.ui.ant.JbiShutdownComponentTask"/>
>+ <!-- jbi shared library task definitions -->
>+ <taskdef name="jbi-install-shared-library" classname="com.sun.jbi.ui.ant.JbiInstallSharedLibraryTask"/>
>+ <taskdef name="jbi-uninstall-shared-library" classname="com.sun.jbi.ui.ant.JbiUninstallSharedLibraryTask"/>
>+ <!-- jbi service assembly deployment tasks definitions -->
>+ <taskdef name="jbi-deploy-service-assembly" classname="com.sun.jbi.ui.ant.JbiDeployServiceAssemblyTask"/>
>+ <taskdef name="jbi-undeploy-service-assembly" classname="com.sun.jbi.ui.ant.JbiUndeployServiceAssemblyTask"/>
>+ <taskdef name="jbi-start-service-assembly" classname="com.sun.jbi.ui.ant.JbiStartServiceAssemblyTask"/>
>+ <taskdef name="jbi-stop-service-assembly" classname="com.sun.jbi.ui.ant.JbiStopServiceAssemblyTask"/>
>+ <taskdef name="jbi-shut-down-service-assembly" classname="com.sun.jbi.ui.ant.JbiShutdownServiceAssemblyTask"/>
>+ <!-- jbi query tasks definitions -->
>+ <taskdef name="jbi-list-service-engines" classname="com.sun.jbi.ui.ant.JbiListServiceEnginesTask"/>
>+ <taskdef name="jbi-list-binding-components" classname="com.sun.jbi.ui.ant.JbiListBindingComponentsTask"/>
>+ <taskdef name="jbi-list-shared-libraries" classname="com.sun.jbi.ui.ant.JbiListSharedLibrariesTask"/>
>+ <taskdef name="jbi-list-service-assemblies" classname="com.sun.jbi.ui.ant.JbiListServiceAssembliesTask"/>
>+ <!-- END - Jbi Ant Task definitions -->
>+
> </antlib>
>Index: apache/tools/ant/taskdefs/defaults.properties
>===================================================================
>RCS file: /cvs/glassfish/appserv-commons/src/java/org/apache/tools/ant/taskdefs/defaults.properties,v
>retrieving revision 1.5
>diff -u -r1.5 defaults.properties
>--- apache/tools/ant/taskdefs/defaults.properties 25 Dec 2005 04:12:43 -0000 1.5
>+++ apache/tools/ant/taskdefs/defaults.properties 2 Nov 2006 21:31:06 -0000
>@@ -243,3 +243,27 @@
> sun-appserv-input=org.apache.tools.ant.taskdefs.Input
> sun-appserv-jspc=org.apache.tools.ant.taskdefs.optional.sun.appserv.SunJspc
> sun-appserv-update=org.apache.tools.ant.taskdefs.optional.sun.appserv.UpdateTask
>+
>+# BEGIN - Jbi Ant Task definitions
>+# jbi component tasks definitions
>+jbi-install-component=com.sun.jbi.ui.ant.JbiInstallComponentTask
>+jbi-uninstall-component=com.sun.jbi.ui.ant.JbiUninstallComponentTask
>+jbi-start-component=com.sun.jbi.ui.ant.JbiStartComponentTask
>+jbi-stop-component=com.sun.jbi.ui.ant.JbiStopComponentTask
>+jbi-shut-down-component=com.sun.jbi.ui.ant.JbiShutdownComponentTask
>+# jbi shared library task definitions
>+jbi-install-shared-library=com.sun.jbi.ui.ant.JbiInstallSharedLibraryTask
>+jbi-uninstall-shared-library=com.sun.jbi.ui.ant.JbiUninstallSharedLibraryTask
>+# jbi service assembly deployment tasks definitions
>+jbi-deploy-service-assembly=com.sun.jbi.ui.ant.JbiDeployServiceAssemblyTask
>+jbi-undeploy-service-assembly=com.sun.jbi.ui.ant.JbiUndeployServiceAssemblyTask
>+jbi-start-service-assembly=com.sun.jbi.ui.ant.JbiStartServiceAssemblyTask
>+jbi-stop-service-assembly=com.sun.jbi.ui.ant.JbiStopServiceAssemblyTask
>+jbi-shut-down-service-assembly=com.sun.jbi.ui.ant.JbiShutdownServiceAssemblyTask
>+# jbi query tasks definitions
>+jbi-list-service-engines=com.sun.jbi.ui.ant.JbiListServiceEnginesTask
>+jbi-list-binding-components=com.sun.jbi.ui.ant.JbiListBindingComponentsTask
>+jbi-list-shared-libraries=com.sun.jbi.ui.ant.JbiListSharedLibrariesTask
>+jbi-list-service-assemblies=com.sun.jbi.ui.ant.JbiListServiceAssembliesTask
>+# END - Jbi Ant Task definitions
>+
>
>