admin@glassfish.java.net

Re: Code review for templates

From: Lloyd L Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Thu, 30 Nov 2006 10:05:45 -0800

Kedar,

No, I've not been maintaining a list of incompatible changes since I
don't think there have been any in AMX. I guess it's time to start
though.

Lloyd

On Nov 29, 2006, at 6:48 PM, kedar wrote:

> Hi Lloyd,
>
> I agree, let's do paperwork once.
>
> As far as this particular change to the "templates" is concerned,
> it is not incompatible. This particular change only removes the
> attribute from a default template, in which case, anyone depending
> upon it will receive the value from the DTD. In other words,
>
> things before this change:
>
> DTD: <!ATTLIST security-service anonymous-role CDATA
> "ANYONE" ...>
> Template: ... <security-service anonymous-role="ANYONE"...>
>
> After this change:
>
> DTD: <!ATTLIST security-service anonymous-role CDATA
> "ANYONE" ...>
>
> All clients are oblivious to if the default value comes from
> domain.xml
> or from its DTD.
>
> Now, coming to the bigger issue of removal from the DTD, it was
> decided
> to leave it in the DTD as a deprecated attribute.
>
> The
> - change in default value of this attribute
> - AMX interface/implementation changes
>
> are *incompatible*. Let's add them to the list of incompatibilities.
> Are you maintaining that list? If yes, can you please let us know the
> deadline for submitting such incompatible changes for inclusion there?
>
> Thanks,
> Kedar
>
> Lloyd L Chambers wrote:
>> Kedar/Shing Wai,
>>
>> If this is an incompatible change, it requires addition to the
>> WSARC case for AppServer 9.1 as well as the Change Control Committed.
>>
>> I think it would be best if all such incompatible changes were
>> collected, and one effort made to do this paperwork for all of them.
>>
>> Lloyd
>> On Nov 29, 2006, at 6:01 PM, kedar wrote:
>>
>>> Looks good.
>>> Copying admin alias.
>>>
>>> The idea is: we are deprecating this unused DTD attribute for
>>> security-service element of a server's config in domain_1_3.dtd.
>>>
>>> This change only covers the default template change.
>>>
>>> Thanks,
>>> Kedar
>>>
>>> Shing-Wai.Chan_at_Sun.COM wrote:
>>>> Hi Kedar,
>>>> Can you review the templates changes below?
>>>> Thanks.
>>>> Shing Wai Chan
>>>>
>>>> cvs diff default-config.xml
>>>> Index: default-config.xml
>>>> ===================================================================
>>>> RCS file: /cvs/glassfish/admin/templates/pe80/default-config.xml,v
>>>> retrieving revision 1.1
>>>> diff -r1.1 default-config.xml
>>>> 70c70
>>>> < <security-service default-realm="file" anonymous-
>>>> role="ANYONE" audit-enabled="false" jacc="default" audit-
>>>> modules="default">
>>>> ---
>>>> > <security-service default-realm="file" audit-enabled="false"
>>>> jacc="default" audit-modules="default">
>>>>
>>>> cvs diff default-domain.xml.template
>>>> Index: default-domain.xml.template
>>>> ===================================================================
>>>> RCS file: /cvs/glassfish/admin/templates/pe80/default-
>>>> domain.xml.template,v
>>>> retrieving revision 1.47
>>>> diff -r1.47 default-domain.xml.template
>>>> 102c102
>>>> < <security-service default-realm="file" anonymous-
>>>> role="ANYONE" audit-enabled="false" jacc="default" audit-
>>>> modules="default">
>>>> ---
>>>> > <security-service default-realm="file" audit-
>>>> enabled="false" jacc="default" audit-modules="default">
>>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>