admin@glassfish.java.net

Re: Code Review Needed

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Mon, 30 Oct 2006 17:35:44 -0800

Byron Nevins wrote:
> This is a new utility class. It is designed for taking the drudgery out
> of attaching threads to stdout and stderr of processes created in java.

Sure would be nice if it followed our coding conventions...

There seems to be no synchronization of the objects shared between the
worker threads and the calling thread.

None of the output streams opened are ever closed.

If I ask for stdout and stderr, I think I want them interleaved in time,
not accumulated separately and concatenated.

The example in the javadocs uses different method names.

Rather than creating threads directly, should it be using an Executor?