Re: [code review] for jbi asadmin updates
I will review this.
Mark Saunders wrote:
> JBI updates to the asadmin code.
>
> 1. Made changes to the JBI_Commands class. Code was added to format
> the output for the JBI show commands.
> 2. Added the code to process the JBI service assembly deployment
> results.
>
>------------------------------------------------------------------------
>
>? admin-cli.log
>? build
>? diff.txt
>? commands/build
>? commands/src/java/com/sun/enterprise/cli/commands/CLIDescriptor.jbi
>? commands/src/java/com/sun/enterprise/cli/commands/CLIDescriptor.jbixx
>? commands/src/java/com/sun/enterprise/cli/commands/Shortcut to commands.lnk
>? commands/tests/java/com/sun/enterprise/cli/commands/StartJBIComponentCommandTest.java
>? commands/tests/java/com/sun/enterprise/cli/commands/TestLogger.java
>? framework/${javadoc.dir}
>? framework/build
>Index: commands/commandsbuild.properties
>===================================================================
>RCS file: /cvs/glassfish/admin-cli/commands/commandsbuild.properties,v
>retrieving revision 1.3
>diff -u -r1.3 commandsbuild.properties
>--- commands/commandsbuild.properties 14 Apr 2006 23:25:03 -0000 1.3
>+++ commands/commandsbuild.properties 6 Sep 2006 22:30:39 -0000
>@@ -38,13 +38,17 @@
> ########
> #on unix
> ########
>-junit.jar=/net/koori.sfbay/onestop/sjsas_ee/8.2/nightly/binaries/solaris/latest/${java.obj.dir}/junit/junit.jar
>-xercesImpl.jar=/net/koori.sfbay/onestop/sjsas_ee/8.2/nightly/binaries/solaris/latest/${java.obj.dir}/jaxrpc-sec/lib/xercesImpl.jar
>+#junit.jar=/net/koori.sfbay/onestop/sjsas_ee/8.2/nightly/binaries/solaris/latest/${java.obj.dir}/junit/junit.jar
>+#xercesImpl.jar=/net/koori.sfbay/onestop/sjsas_ee/8.2/nightly/binaries/solaris/latest/${java.obj.dir}/jaxrpc-sec/lib/xercesImpl.jar
>+
> ######################################################################
> #on windows need to map the network drive Z: to \\koori.sfbay\onestop
> ######################################################################
> #junit.jar=Z:\\sjsas_ee\\8.1\\nightly\\binaries\\solaris\\latest\\JDK1.4_DBG.OBJ\\junit\\junit.jar
> #xercesImpl.jar=Z:\\sjsas_ee\\8.1\\nightly\\binaries\\solaris\\latest\\JDK1.4_DBG.OBJ\\jaxrpc-sec\\lib\\xercesImpl.jar
>+
>+junit.jar=c:/glassfish2/workspace/glassfish/appserv-tests/lib/junit.jar
>+xercesImpl.jar=c:/glassfish2/workspace/glassfish/appserv-tests/lib/xercesImpl.jar
>
> ### Component Properties ###
> src.dir=src/java
>Index: commands/src/java/com/sun/enterprise/cli/commands/JBICommand.java
>===================================================================
>RCS file: /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/JBICommand.java,v
>retrieving revision 1.3
>diff -u -r1.3 JBICommand.java
>--- commands/src/java/com/sun/enterprise/cli/commands/JBICommand.java 3 Oct 2006 21:31:27 -0000 1.3
>+++ commands/src/java/com/sun/enterprise/cli/commands/JBICommand.java 9 Oct 2006 15:34:25 -0000
>@@ -85,6 +85,7 @@
> * This method verifies for the correctness of number of
> * operands and if all the required options are supplied by the client.
> * @return boolean returns true if success else returns false
>+ * @throws CommandValidationException
> */
> public boolean validateOptions() throws CommandValidationException
> {
>@@ -110,6 +111,7 @@
> * @param validOptions An array containing a list of valid options
> * @param defaultValue The default value returned if no option value exists
> * @return The option value
>+ * @throws CommandValidationException
> */
> protected String getOption(String optionName, String[] validOptions, String defaultValue) throws CommandValidationException
> {
>@@ -146,6 +148,7 @@
> * @param optionName The option name use to retrieve the value
> * @param validOptions An array containing a list of valid options
> * @return The option value
>+ * @throws CommandValidationException
> */
> protected String getOption(String optionName, String[] validOptions) throws CommandValidationException
> {
>@@ -247,13 +250,26 @@
> }
>
>
>- public void validateFilePath (String filePath) throws CommandException
>+ /**
>+ * Method that will validate that the given file path exists and is not
>+ * a directory.
>+ * @param filePath The file path
>+ * @throws CommandException
>+ */
>+ protected void validateFilePath (String filePath) throws CommandException
> {
> validateFilePath ("FileDoesNotExist",filePath);
> }
>
>
>- public void validateFilePath (String errorKey, String filePath) throws CommandException
>+ /**
>+ * Method that will validate that the given file path exists and is not
>+ * a directory.
>+ * @param errorKey The property key value used to retrieve the error message text
>+ * @param filePath The file path
>+ * @throws CommandException
>+ */
>+ protected void validateFilePath (String errorKey, String filePath) throws CommandException
> {
> File file = new File(filePath);
> if ((!file.exists()) || (file.isDirectory()))
>@@ -267,6 +283,9 @@
> /**
> * Perform the pre run initialization. This will validate the options as
> * well as retrieve the MBean Server Connection.
>+ * @throws CommandValidationException
>+ * @throws CommandException
>+ * @throws JBIRemoteException
> */
> protected boolean preRunInit() throws CommandValidationException,
> CommandException,
>@@ -280,6 +299,10 @@
> /**
> * Perform the pre run initialization. This will validate the options as
> * well as retrieve the MBean Server Connection.
>+ * @param uploadFlag The upload flag
>+ * @throws CommandValidationException
>+ * @throws CommandException
>+ * @throws JBIRemoteException
> */
> protected boolean preRunInit(boolean uploadFlag) throws CommandValidationException,
> CommandException,
>@@ -299,7 +322,7 @@
>
> // Retrieve the JBI Admin Command object
> try {
>- //mJbiAdminCommands = JBIAdminCommandsClientFactory.getInstance(mbsc,uploadFlag);
>+ // mJbiAdminCommands = JBIAdminCommandsClientFactory.getInstance(mbsc,uploadFlag);
> mJbiAdminCommands = JBIAdminCommandsClientFactory.getInstance(mbsc);
> }
> catch (Exception e) {
>@@ -372,119 +395,184 @@
> }
>
>
>- protected void processJBIAdminShowComponentResult (String result)
>+ /**
>+ * Will format and display the component (binding or engine) show results.
>+ * @param result the xml string containing the result information
>+ * @param aName the name of the component
>+ */
>+ protected void processJBIAdminShowComponentResult (String result, String aName)
> {
> List list = JBIComponentInfo.readFromXmlText(result);
> if (list.size() == 0)
> {
> CLILogger.getInstance().printDetailMessage (
>- getLocalizedString ("NoComponentToShow",new Object[] {result}));
>+ getLocalizedString ("JBINoComponentToShow",new Object[] {aName}));
> }
> else
> {
>+ CLILogger.getInstance().printDetailMessage ("");
>+ String header = getLocalizedString ("JBIComponentShowHeader");
>+ CLILogger.getInstance().printDetailMessage (header);
>+ CLILogger.getInstance().printDetailMessage (createFillString('-',header.length()));
>+
> Iterator it = list.iterator();
>- String listBreak = "";
>- int count = 0;
> JBIComponentInfo info = ((JBIComponentInfo)it.next());
> String componentName = info.getName();
> String componentState = info.getState();
> String componentDescription = info.getDescription();
>- String trimedDescription = componentDescription.trim();
>+ String formattedDescription = formatDescription(componentDescription,50,14);
> CLILogger.getInstance().printDetailMessage (
>- getLocalizedString ("JBIShowName",new Object[] {componentName}));
>+ getLocalizedString ("JBIComponentName",new Object[] {componentName}));
> CLILogger.getInstance().printDetailMessage (
>- getLocalizedString ("JBIShowState",new Object[] {componentState}));
>+ getLocalizedString ("JBIComponentState",new Object[] {componentState}));
> CLILogger.getInstance().printDetailMessage (
>- (getLocalizedString ("JBIShowDescription",new Object[] {trimedDescription})));
>- }
>+ getLocalizedString ("JBIComponentDescription",new Object[] {formattedDescription}));
>+ }
> }
>
>
>- protected void processJBIAdminShowLibraryResult (String result)
>+ /**
>+ * Will format and display the Shared Library show results.
>+ * @param result the xml string containing the result information
>+ * @param aName the name of the shared library
>+ */
>+ protected void processJBIAdminShowLibraryResult (String result, String aName)
> {
> List list = JBIComponentInfo.readFromXmlText(result);
> if (list.size() == 0)
> {
> CLILogger.getInstance().printDetailMessage (
>- getLocalizedString ("NoLibraryToShow",new Object[] {result}));
>+ getLocalizedString ("JBINoLibraryToShow",new Object[] {aName}));
> }
> else
> {
>+ CLILogger.getInstance().printDetailMessage ("");
>+ String header = getLocalizedString ("JBISharedLibraryShowHeader");
>+ CLILogger.getInstance().printDetailMessage (header);
>+ CLILogger.getInstance().printDetailMessage (createFillString('-',header.length()));
>+
> Iterator it = list.iterator();
>- String listBreak = "";
>- int count = 0;
> JBIComponentInfo info = ((JBIComponentInfo)it.next());
>- String componentName = info.getName();
>- String componentDescription = info.getDescription();
>- String trimedDescription = componentDescription.trim();
>+ String libraryName = info.getName();
>+ String libraryDescription = info.getDescription();
>+ String formattedDescription = formatDescription(libraryDescription,50,14);
> CLILogger.getInstance().printDetailMessage (
>- getLocalizedString ("JBIShowName",new Object[] {componentName}));
>+ getLocalizedString ("JBISharedLibraryName",new Object[] {libraryName}));
> CLILogger.getInstance().printDetailMessage (
>- (getLocalizedString ("JBIShowDescription",new Object[] {trimedDescription})));
>+ getLocalizedString ("JBISharedLibraryDescription",new Object[] {formattedDescription}));
> }
> }
>
>
>- protected void processJBIAdminShowAssemblyResult (String result)
>+ /**
>+ * Will format and display the Service Assembly show results.
>+ * @param result the xml string containing the result information
>+ * @param aName the name of the service assembly
>+ */
>+ protected void processJBIAdminShowAssemblyResult (String result, String aName)
> {
>- CLILogger.getInstance().printDetailMessage ("Command Not Implemented");
>- return;
>- /*
> List list = ServiceAssemblyInfo.readFromXmlTextWithProlog(result);
>
> if ( list.size() <= 0 )
> {
>- System.out.println ("Bad Name ***");
>+ CLILogger.getInstance().printDetailMessage (
>+ getLocalizedString ("JBINoServiceAssemblyToShow",new Object[] {aName}));
> }
> else
> {
>- for ( Iterator itr = list.iterator(); itr.hasNext();)
>- {
>- ServiceAssemblyInfo saInfo = (ServiceAssemblyInfo) itr.next();
>- List suInfoList = saInfo.getServiceUnitInfoList();
>+ Iterator itr = list.iterator();
>+ ServiceAssemblyInfo saInfo = (ServiceAssemblyInfo) itr.next();
>+ List suInfoList = saInfo.getServiceUnitInfoList();
>+
>+ String saName = saInfo.getName();
>+ String saState = saInfo.getState();
>+ String saDescription = saInfo.getDescription();
>+ String saSize = Integer.toString(suInfoList.size());
>+ String formattedSADescription = formatDescription(saDescription,50,16);
>+
>+ CLILogger.getInstance().printDetailMessage ("");
>+ String SAHeader = getLocalizedString ("JBIServiceAssemblyShowHeader");
>+ CLILogger.getInstance().printDetailMessage (SAHeader);
>+ CLILogger.getInstance().printDetailMessage (createFillString('-',SAHeader.length()));
>+ CLILogger.getInstance().printDetailMessage (
>+ getLocalizedString ("JBIServiceAssemblyName",new Object[] {saName}));
>+ CLILogger.getInstance().printDetailMessage (
>+ getLocalizedString ("JBIServiceAssemblyState",new Object[] {saState}));
>+ CLILogger.getInstance().printDetailMessage (
>+ getLocalizedString ("JBIServiceAssemblyServiceUnits",new Object[] {saSize}));
>+ CLILogger.getInstance().printDetailMessage (
>+ getLocalizedString ("JBIServiceAssemblyDescription",new Object[] {formattedSADescription}));
>+
>+ String indentString = " ";
>+ CLILogger.getInstance().printDetailMessage ("");
>+ String SUHeader = getLocalizedString ("JBIServiceUnitShowHeader");
>+ CLILogger.getInstance().printDetailMessage (indentString + SUHeader);
>+ CLILogger.getInstance().printDetailMessage (indentString + createFillString('-',SUHeader.length()));
>+ boolean firstTime = true;
>+ for (Iterator suItr = suInfoList.iterator(); suItr.hasNext();)
>+ {
>+ ServiceUnitInfo suInfo = (ServiceUnitInfo ) suItr.next();
>+ String suState = suInfo.getState();
>+ String suDepoyedOn = suInfo.getDeployedOn();
>+ String suName = suInfo.getName();
>+ String suDescription = suInfo.getDescription();
>+ String formattedSUDescription = formatDescription(suDescription,50,18);
>+ if (!(firstTime))
>+ {
>+ CLILogger.getInstance().printDetailMessage ("");
>+ }
>+ CLILogger.getInstance().printDetailMessage (indentString +
>+ getLocalizedString ("JBIServiceUnitName",new Object[] {suName}));
>+ CLILogger.getInstance().printDetailMessage (indentString +
>+ getLocalizedString ("JBIServiceUnitState",new Object[] {suState}));
>+ CLILogger.getInstance().printDetailMessage (indentString +
>+ getLocalizedString ("JBIServiceUnitDeployedOn",new Object[] {suDepoyedOn}));
>+ CLILogger.getInstance().printDetailMessage (indentString +
>+ getLocalizedString ("JBIServiceUnitDescription",new Object[] {formattedSUDescription}));
>+ firstTime = false;
>+ }
>+ }
>+ }
>
>- String saName = saInfo.getName();
>- String saState = saInfo.getState();
>- String saDescription = saInfo.getDescription();
>- String saSize = Integer.toString(suInfoList.size());
>-
>- System.out.println ("Name: " + saName);
>- System.out.println ("State: " + saState);
>- System.out.println ("Description: " + saDescription);
>- System.out.println ("Size: " + saSize);
>
>- for ( Iterator suItr = suInfoList.iterator(); suItr.hasNext(); )
>+ /**
>+ * ** Still Under Development **
>+ * Will process the list results for the Service Assemblies
>+ * @param result The result xml string
>+ */
>+ protected void processJBIDeployResult (String result)
>+ {
>+ JBIManagementMessage mgmtMsg =
>+ JBIManagementMessage.createJBIManagementMessage(result);
>+ if (mgmtMsg == null)
>+ {
>+ CLILogger.getInstance().printDetailMessage (result);
>+ }
>+ else
>+ {
>+ if (mgmtMsg.isSuccessMsg())
>+ {
>+ String msg = mgmtMsg.getMessage();
>+ int index = msg.indexOf(")");
>+ if (index != -1)
> {
>- ServiceUnitInfo suInfo = (ServiceUnitInfo ) suItr.next();
>-
>- String suState = suInfo.getState();
>- String suDepoyedOn = suInfo.getDeployedOn();
>- String suName = suInfo.getName();
>- String suDescription = suInfo.getDescription();
>-
>- System.out.println ("Service Unit: " + suName);
>- System.out.println ("State: " + suState);
>- System.out.println ("Deployed On: " + suDepoyedOn);
>- System.out.println ("Description: " + suDescription);
>- System.out.println ("");
>+ msg = msg.substring(index+1);
> }
>-
>+ CLILogger.getInstance().printDetailMessage (msg);
>+ }
>+ else
>+ {
>+ String msg = mgmtMsg.getMessage();
>+ CLILogger.getInstance().printDetailMessage (msg);
> }
> }
>- */
>- }
>-
>-
>- // Will be removed when files using this method are deleted
>- protected void processJBIAdminResult (String result)
>- {
> }
>
>
> /**
>- * ** Still Under Development **
> * Will process the task exception to display the error message.
>- * @param the exception to process
>+ * @param ex the exception to process
>+ * @throws CommandException
> */
> protected void processTaskException (Exception ex) throws CommandException
> {
>@@ -504,9 +592,8 @@
>
>
> /**
>- * ** Still Under Development **
> * Will extract the JBIManagementMessgae from the Remote exception.
>- * @param the exception to process
>+ * @param ex the exception to process
> */
> protected JBIManagementMessage extractJBIManagementMessage (Exception ex )
> {
>@@ -522,6 +609,82 @@
> mgmtMsg = JBIManagementMessage.createJBIManagementMessage(exMessage);
> }
> return mgmtMsg;
>+ }
>+
>+
>+ /**
>+ * Will create a string of the size specified filled with the fillChar.
>+ * @param fillChar the character to create the string with
>+ * @param the size of the string
>+ */
>+ private String createFillString (char fillChar, int size)
>+ {
>+ String fillString = "";
>+ for (int i=0; i<size; i++)
>+ {
>+ fillString += fillChar;
>+ }
>+ return fillString;
>+ }
>+
>+
>+ /**
>+ * Will format the description text that is displayed in the show commands. The
>+ * formatting will consist of removing all new lines and extra white space, then
>+ * adding back in line breaks at the first avaliable location that is less then
>+ * or equal to the given max line length.
>+ * @param description the description text to format
>+ * @param maxLength the maximum line length size.
>+ * @param indentAmout the amount to indent row 2 - n
>+ */
>+ private String formatDescription (String description, int maxLength, int indentAmount)
>+ {
>+ int endIndex = 0;
>+ int startIndex = 0;
>+ String finalString = "";
>+ String rowString = "";
>+ String space = "";
>+ endIndex = description.indexOf("\n",startIndex);
>+ while (endIndex != -1)
>+ {
>+ rowString = description.substring(startIndex,endIndex).trim();
>+ finalString += space + rowString;
>+ startIndex = endIndex + 1;
>+ endIndex = description.indexOf("\n",startIndex);
>+ space = " ";
>+ }
>+ rowString = description.substring(startIndex).trim();
>+ finalString += space + rowString;
>+
>+ // Format the string by adding the line breaks and the indention
>+ endIndex = 0;
>+ startIndex = 0;
>+ int spaceIndex = 0;
>+ int indentSize = 0;
>+ String newString = "";
>+ boolean done = false;
>+ int totalLength = finalString.length();
>+
>+ while (!(done))
>+ {
>+ endIndex = ((startIndex + maxLength) > totalLength) ? totalLength : (startIndex + maxLength);
>+ rowString = finalString.substring(startIndex,endIndex);
>+ spaceIndex = startIndex + rowString.lastIndexOf(" ");
>+ if (spaceIndex != -1)
>+ {
>+ endIndex = spaceIndex;
>+ }
>+ rowString = finalString.substring(startIndex,endIndex) + "\n";
>+ startIndex = endIndex + 1;
>+ newString += createFillString(' ',indentSize) + rowString;
>+ indentSize = indentAmount;
>+ if (startIndex == totalLength)
>+ {
>+ done = true;
>+ }
>+ }
>+ finalString = newString.trim();
>+ return finalString;
> }
>
> }
>Index: commands/src/java/com/sun/enterprise/cli/commands/JBIInstallCommands.java
>===================================================================
>RCS file: /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/JBIInstallCommands.java,v
>retrieving revision 1.1
>diff -u -r1.1 JBIInstallCommands.java
>--- commands/src/java/com/sun/enterprise/cli/commands/JBIInstallCommands.java 3 Oct 2006 21:31:27 -0000 1.1
>+++ commands/src/java/com/sun/enterprise/cli/commands/JBIInstallCommands.java 6 Oct 2006 17:18:08 -0000
>@@ -43,6 +43,7 @@
> /**
> * A method that Executes the command
> * @throws CommandException
>+ * @throws CommandValidationException
> */
> public void runCommand() throws CommandException, CommandValidationException
> {
>@@ -57,7 +58,7 @@
> if (preRunInit(isUpload))
> {
> // Retrieve the options
>- String targetName = getOption(TARGET_OPTION);
>+ String targetName = getOption(TARGET_OPTION);
>
> // Retrieve the operand
> String filePath = (String) getOperands().get(0);
>@@ -71,6 +72,8 @@
> filePath,
> targetName);
> successKey = "JBISuccessInstallComponent";
>+ CLILogger.getInstance().printDetailMessage (
>+ getLocalizedString ("JBISuccessInstallComponent",new Object[] {name}));
> }
>
> else if (name.equals(INSTALL_SHARED_LIBRARY)) {
>@@ -78,18 +81,16 @@
> filePath,
> targetName);
> successKey = "JBISuccessInstallSharedLibrary";
>+ CLILogger.getInstance().printDetailMessage (
>+ getLocalizedString ("JBISuccessInstallSharedLibrary",new Object[] {name}));
> }
>
> else if (name.equals(DEPLOY_SERVICE_ASSEMBLY)) {
> result = ((JBIAdminCommands) mJbiAdminCommands).deployServiceAssembly(
> filePath,
> targetName);
>- successKey = "JBISuccessDeployServiceAssembly";
>+ processJBIDeployResult(result);
> }
>-
>- // Display the success message
>- CLILogger.getInstance().printDetailMessage (
>- getLocalizedString (successKey,new Object[] {result}));
> }
> }
>
>Index: commands/src/java/com/sun/enterprise/cli/commands/JBIShowCommands.java
>===================================================================
>RCS file: /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/JBIShowCommands.java,v
>retrieving revision 1.1
>diff -u -r1.1 JBIShowCommands.java
>--- commands/src/java/com/sun/enterprise/cli/commands/JBIShowCommands.java 3 Oct 2006 21:31:28 -0000 1.1
>+++ commands/src/java/com/sun/enterprise/cli/commands/JBIShowCommands.java 6 Oct 2006 00:44:54 -0000
>@@ -66,7 +66,7 @@
> "",
> "",
> targetName);
>- processJBIAdminShowComponentResult(result);
>+ processJBIAdminShowComponentResult(result,componentName);
> }
>
> else if (name.equals(SHOW_SERVICE_ENGINE)) {
>@@ -76,7 +76,7 @@
> "",
> "",
> targetName);
>- processJBIAdminShowComponentResult(result);
>+ processJBIAdminShowComponentResult(result,componentName);
> }
>
> else if (name.equals(SHOW_SHARED_LIBRARY)) {
>@@ -84,7 +84,7 @@
> componentName,
> "",
> targetName);
>- processJBIAdminShowLibraryResult(result);
>+ processJBIAdminShowLibraryResult(result,componentName);
> }
>
> else if (name.equals(SHOW_SERVICE_ASSEMBLY)) {
>@@ -93,7 +93,7 @@
> "",
> "",
> targetName);
>- processJBIAdminShowAssemblyResult(result);
>+ processJBIAdminShowAssemblyResult(result,componentName);
> }
> }
> }
>Index: commands/src/java/com/sun/enterprise/cli/commands/LocalStrings.properties
>===================================================================
>RCS file: /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/LocalStrings.properties,v
>retrieving revision 1.39
>diff -u -r1.39 LocalStrings.properties
>--- commands/src/java/com/sun/enterprise/cli/commands/LocalStrings.properties 3 Oct 2006 21:31:29 -0000 1.39
>+++ commands/src/java/com/sun/enterprise/cli/commands/LocalStrings.properties 6 Oct 2006 00:51:26 -0000
>@@ -75,21 +75,43 @@
> database.driver.name.msg=Clients can connect to the database using: [{0}].
> database.driver.version.msg=Database Driver Version: [{0}]
> jdbc.version.msg=JDBC Specification Version: [{0}]
>-JBISuccessInstallSharedLibrary=Installed shared library {0}.
>-JBISuccessInstallComponent=Installed component {0}.
>-JBISuccessDeployServiceAssembly=Deployed service assembly {0}.
>-JBISuccessUninstallSharedLibrary=Uninstalled shared library {0}.
>-JBISuccessUninstallComponent=Uninstalled component {0}.
>-JBISuccessUndeployServiceAssembly=Undeployed service assembly {0}.
>-JBISuccessStartedComponent=Started component {0}.
>-JBISuccessStoppedComponent=Stopped component {0}.
>-JBISuccessShutDownComponent=Shut Down component {0}.
>-JBISuccessStartAssemblyComponent=Started service assembly {0}.
>-JBISuccessStoppedAssembly=Stopped service assembly {0}.
>-JBISuccessShutDownAssembly=Shut Down service assembly {0}.
>-JBIShowName=Name: {0}
>-JBIShowState=State: {0}
>-JBIShowDescription=Descripition: {0}
>+
>+JBISuccessInstallSharedLibrary = Installed shared library {0}.
>+JBISuccessInstallComponent = Installed component {0}.
>+JBISuccessDeployServiceAssembly = Deployed service assembly {0}.
>+JBISuccessUninstallSharedLibrary = Uninstalled shared library {0}.
>+JBISuccessUninstallComponent = Uninstalled component {0}.
>+JBISuccessUndeployServiceAssembly = Undeployed service assembly {0}.
>+JBISuccessStartedComponent = Started component {0}.
>+JBISuccessStoppedComponent = Stopped component {0}.
>+JBISuccessShutDownComponent = Shut Down component {0}.
>+JBISuccessStartAssemblyComponent = Started service assembly {0}.
>+JBISuccessStoppedAssembly = Stopped service assembly {0}.
>+JBISuccessShutDownAssembly = Shut Down service assembly {0}.
>+JBIShowName = Name: {0}
>+JBIShowState = State: {0}
>+JBIShowDescription = Descripition: {0}
>+
>+JBIComponentShowHeader = Shared Component Information
>+JBIComponentName = Name : {0}
>+JBIComponentState = State : {0}
>+JBIComponentDescription = Description : {0}
>+
>+JBISharedLibraryShowHeader = Shared Library Information
>+JBISharedLibraryName = Name : {0}
>+JBISharedLibraryDescription = Description : {0}
>+
>+JBIServiceAssemblyShowHeader = Service Assembly Information
>+JBIServiceAssemblyName = Name : {0}
>+JBIServiceAssemblyState = State : {0}
>+JBIServiceAssemblyServiceUnits = Service Units : {0}
>+JBIServiceAssemblyDescription = Description : {0}
>+
>+JBIServiceUnitShowHeader = Service Unit Information
>+JBIServiceUnitName = Name : {0}
>+JBIServiceUnitState = State : {0}
>+JBIServiceUnitDeployedOn = Deployed On : {0}
>+JBIServiceUnitDescription = Description : {0}
>
> #Error Messages
> CouldNotInvokeCommand=CLI126 Error invoking command, {0}
>@@ -231,3 +253,4 @@
> JBIDeloymentFileNotFound=CLI202 Deployment failed. The file {0} could not be found.
> JBINoComponentToShow=CLI203 The component specified {0} does not exist.
> JBINoLibraryToShow=CLI204 The shared library specified {0} does not exist.
>+JBINoServiceAssemblyToShow=CLI205 The service assembly specified {0} does not exist.
>Index: commands/tests/java/com/sun/enterprise/cli/commands/AllTest.java
>===================================================================
>RCS file: /cvs/glassfish/admin-cli/commands/tests/java/com/sun/enterprise/cli/commands/AllTest.java,v
>retrieving revision 1.4
>diff -u -r1.4 AllTest.java
>--- commands/tests/java/com/sun/enterprise/cli/commands/AllTest.java 25 Dec 2005 03:46:42 -0000 1.4
>+++ commands/tests/java/com/sun/enterprise/cli/commands/AllTest.java 6 Sep 2006 18:42:48 -0000
>@@ -60,6 +60,7 @@
> UnsetCommandTest.class,
> VerifyDomainXmlCommandTest.class,
> WebServiceRegistryCommandTest.class,
>+ StartJBIComponentCommandTest.class,
> };
>
> public static Test suite(){
>
>
>
>------------------------------------------------------------------------
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: admin-unsubscribe_at_glassfish.dev.java.net
>For additional commands, e-mail: admin-help_at_glassfish.dev.java.net
>
>