jsr322-experts@connector-spec.java.net

[jsr322-experts] Re: Please review the first draft of the Connectors 1.7 specification

From: Sivakumar Thyagarajan <sivakumar.thyagarajan_at_oracle.com>
Date: Tue, 29 Jan 2013 16:07:11 +0530

Hi Wilson

On Tuesday 29 January 2013 12:06 PM, Wilson Tian wrote:
> Hi all,

Thanks for your detailed review and comments. Please find my responses
inline. I will address these changes in the final version that should be
sent to this ML by Friday/Saturday this week.

> Here are a few minor comments:
>
> 1. update text in Section 18.9.2 @AdministeredObjectDefinition:
> "The fully qualified class name of the administered object's interface must be indicated by the interfaceName element only if the class indicated in the className element implements more than one interface."
> To
> " ... only if the class indicated in the className element implements more than one Interface and application server cannot determine the unique Java interface of the administered object according the rules defined in section 18.8 @AdministeredObject."

Sure, will do.

> 2. update rules in section 18.8 @AdministeredObject, to auto-exclude ResourceAdapterAssociation also.

Good catch, will do.

> 3. clarify in section 18.9 that these 2 annotations can only be put in modules which have accessibility to the resource adapter according to section 20.2.0.4 Requirements.

Yes, agreed and will do.

> 4. clarify in section 18.9.1.1 Example and 18.9.2.1 Example,
> "Once defined, a connector connection factory/Queue resource may be referenced by a component, ,using the resource-ref deployment descriptor element or the Resource annotation."
> To
> "... may be referenced by a component, which has accessibility to the resource adapter according to section 20.2.0.4 Requirements, using the resource-ref ..."
> Or, put these clarifications to section 18.9 with #3 above together.

Agreed. This is implied by 20.2.0.4, but I will address #3 in the common
section 18.9 and add a note about this too.

Thanks
--Siva.