Hi Anthony,
Here is some more feedback on PR:
- In this code:
@Resource(name = "concurrent/myFactory")
ManagedThreadFactory factory;
factory.newThread(new MyTask(5));
newThread returns a Thread instead of ManageableThread. Shouldn't it
return the later ?
- Shouldn't ManageableThread inherit from java.lang.Thread ?
- How are ManageableThreadFactory and ManagedExecutorService use cases
different ? I can create bunch of threads from the former and create my
own thread pool or executor service.
- IMHO ManagedThread is a better name than ManageableThread.
- There is a default ManagedThreadFactory. Should it be in the
concurrent namespace, i.e.
java:comp/concurrent/DefaultManagedThreadFactory
instead of
java:comp/DefaultManagedThreadFactory Concurrency Utilities for Java EE
Concurrency Utilities for Java EE
- Will the code:
@Resource
ManagedThreadFactory factory;
be equivalent to:
@Resource(lookup="DefaultManagedThreadFactory")
ManagedThreadFactory factory;
Thanks,
Arun
--
http://twitter.com/arungupta
http://blogs.oracle.com/arungupta