Project: javamail
Repository: mercurial
Revision: 675
Author: shannon
Date: 2014-12-01 22:29:28 UTC
Link:
Log Message:
------------
Exclude false positive FindBugs errors in logging.
Exclude or fix more minor FindBugs errors.
Revisions:
----------
674
675
Modified Paths:
---------------
mail/exclude.xml
mail/src/main/java/com/sun/mail/auth/OAuth2SaslClient.java
Diffs:
------
diff -r 7558fd644dc5 -r 4d922a0b3ba7 mail/exclude.xml
--- a/mail/exclude.xml Wed Nov 26 16:27:20 2014 -0800
+++ b/mail/exclude.xml Mon Dec 01 14:14:38 2014 -0800
@@ -3,7 +3,7 @@
DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
- Copyright (c) 2010-2013 Oracle and/or its affiliates. All rights reserved.
+ Copyright (c) 2010-2014 Oracle and/or its affiliates. All rights reserved.
The contents of this file are subject to the terms of either the GNU
General Public License Version 2 only ("GPL") or the Common Development
@@ -672,4 +672,19 @@
<Bug pattern="SE_NO_SERIALVERSIONID"/>
</Match>
+ <!--
+ These array references are declared volatile because they're
+ treated as copy-on-write.
+ -->
+ <Match>
+ <Class name="com.sun.mail.util.logging.LogManagerProperties"/>
+ <Field name="REFLECT_NAMES"/>
+ <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+ </Match>
+ <Match>
+ <Class name="com.sun.mail.util.logging.MailHandler"/>
+ <Field name="attachmentFilters"/>
+ <Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
+ </Match>
+
</FindBugsFilter>
diff -r 4d922a0b3ba7 -r c2a7b6497852 mail/exclude.xml
--- a/mail/exclude.xml Mon Dec 01 14:14:38 2014 -0800
+++ b/mail/exclude.xml Mon Dec 01 14:29:28 2014 -0800
@@ -231,6 +231,11 @@
</Or>
<Bug pattern="REC_CATCH_EXCEPTION"/>
</Match>
+ <Match>
+ <Class name="com.sun.mail.imap.IMAPFolder"/>
+ <Method name="handleIdle"/>
+ <Bug pattern="DE_MIGHT_IGNORE"/>
+ </Match>
<!--
FindBugs complains about a possible double check of headersLoaded,
@@ -540,6 +545,7 @@
<Class name="com.sun.mail.imap.IMAPFolder$4"/>
<Class name="com.sun.mail.imap.IMAPFolder$7"/>
<Class name="com.sun.mail.imap.IMAPFolder$13"/>
+ <Class name="com.sun.mail.imap.IMAPFolder$20"/>
</Or>
<Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON"/>
</Match>
diff -r 4d922a0b3ba7 -r c2a7b6497852 mail/src/main/java/com/sun/mail/auth/OAuth2SaslClient.java
--- a/mail/src/main/java/com/sun/mail/auth/OAuth2SaslClient.java Mon Dec 01 14:14:38 2014 -0800
+++ b/mail/src/main/java/com/sun/mail/auth/OAuth2SaslClient.java Mon Dec 01 14:29:28 2014 -0800
@@ -61,11 +61,11 @@
*/
public class OAuth2SaslClient implements SaslClient {
private CallbackHandler cbh;
- private Map<String,?> props; // XXX - not currently used
+ //private Map<String,?> props; // XXX - not currently used
private boolean complete = false;
public OAuth2SaslClient(Map<String,?> props, CallbackHandler cbh) {
- this.props = props;
+ //this.props = props;
this.cbh = cbh;
}