Issue Number: 6667
Tests Run: PE QL
Approved by: Self. Required for Sun Tech Days in China for a demo.


Synopsis

The issue is confirmed, the query getPieIInformation sums up numbers of type 'long' from the various 
tables. On the first request to the server, the processing time is slower as compared to subsequent 
requests. I presume it is because of jsp compilations. Subsequent requests are much faster. 

So on the first request (and the first request only) for this sample application, the return value turns out to 
be too big for BIGINT(SQL equivalent of java long). Replacing BIGINT by DOUBLE does the trick.


Index: src/java/com/sun/enterprise/admin/monitor/callflow/DbAccessObjectImpl.java
===================================================================
RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/admin/monitor/callflow/DbAccessObjectImpl.java,v
retrieving revision 1.20
diff -u -r1.20 DbAccessObjectImpl.java
--- src/java/com/sun/enterprise/admin/monitor/callflow/DbAccessObjectImpl.java	5 May 2007 05:24:18 -0000	1.20
+++ src/java/com/sun/enterprise/admin/monitor/callflow/DbAccessObjectImpl.java	3 Nov 2008 11:24:22 -0000
@@ -591,7 +591,7 @@
             mapST = new HashMap<String, String>();
             while(rs.next()){                             
                 String container_type = rs.getString(1);
-                long time_taken = rs.getLong(2);
+                double time_taken = rs.getDouble(2);
                 mapST.put(container_type, String.valueOf(time_taken));                
             }
             st.close();
@@ -603,7 +603,7 @@
             mapET = new HashMap<String, String>();
             while(rs.next()){                             
                 String container_type = rs.getString(1);
-                long time_taken = rs.getLong(2);
+                double time_taken = rs.getDouble(2);
                 mapET.put(container_type, String.valueOf(time_taken));                
             }
             et.close();
@@ -613,18 +613,18 @@
                 String stime = mapST.get(key);
                 if (stime == null)
                     continue;
-                long startTime = Long.valueOf(stime);
+                double startTime = Double.valueOf(stime);
                 String etime = mapET.get(key);
                 if (etime == null )
                     continue;
-                long endTime = Long.valueOf(etime);
-                long time_taken = endTime - startTime;
+                double endTime = Double.valueOf(etime);
+                double time_taken = endTime - startTime;
                 retMap.put (key, String.valueOf (time_taken));
             }
             
         } catch (SQLException se){
             // log it
-            logger.log(Level.FINE, "callflow.error_get_pie_info", se);             
+            logger.log(Level.SEVERE, "callflow.error_get_pie_info", se);             
         }
         closeConnection();
         return retMap;
Index: src/java/com/sun/enterprise/admin/monitor/callflow/MethodEndAccessObjectImpl.java
===================================================================
RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/admin/monitor/callflow/MethodEndAccessObjectImpl.java,v
retrieving revision 1.13.6.2
diff -u -r1.13.6.2 MethodEndAccessObjectImpl.java
--- src/java/com/sun/enterprise/admin/monitor/callflow/MethodEndAccessObjectImpl.java	5 Aug 2008 21:25:45 -0000	1.13.6.2
+++ src/java/com/sun/enterprise/admin/monitor/callflow/MethodEndAccessObjectImpl.java	3 Nov 2008 11:24:22 -0000
@@ -100,7 +100,7 @@
             for (int i = 0 ; i<transferObject.length; i++) {
                 MethodEndTO methodEndTO = (MethodEndTO)transferObject[i];
                 pstmt.setString(1, methodEndTO.getRequestId());
-                pstmt.setLong(2, methodEndTO.getTimeStamp());
+                pstmt.setDouble(2, utility.longToDouble(methodEndTO.getTimeStamp()));
                 pstmt.setString(3, methodEndTO.getException());
                 pstmt.addBatch();
                 
Index: src/java/com/sun/enterprise/admin/monitor/callflow/MethodStartAccessObjectImpl.java
===================================================================
RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/admin/monitor/callflow/MethodStartAccessObjectImpl.java,v
retrieving revision 1.14.6.2
diff -u -r1.14.6.2 MethodStartAccessObjectImpl.java
--- src/java/com/sun/enterprise/admin/monitor/callflow/MethodStartAccessObjectImpl.java	5 Aug 2008 21:25:45 -0000	1.14.6.2
+++ src/java/com/sun/enterprise/admin/monitor/callflow/MethodStartAccessObjectImpl.java	3 Nov 2008 11:24:23 -0000
@@ -96,7 +96,7 @@
             for (int i = 0 ; i<transferObject.length; i++) {
                 MethodStartTO methodStartTO = (MethodStartTO)transferObject[i];
                 pstmt.setString(1, methodStartTO.getRequestId());
-                pstmt.setLong(2, methodStartTO.getTimeStamp());
+                pstmt.setDouble(2, utility.longToDouble(methodStartTO.getTimeStamp()));
                 
                 if (methodStartTO.getComponentType() != null)
                     pstmt.setString(3, methodStartTO.getComponentType().toString());
Index: src/java/com/sun/enterprise/admin/monitor/callflow/RequestEndAccessObjectImpl.java
===================================================================
RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/admin/monitor/callflow/RequestEndAccessObjectImpl.java,v
retrieving revision 1.12.6.2
diff -u -r1.12.6.2 RequestEndAccessObjectImpl.java
--- src/java/com/sun/enterprise/admin/monitor/callflow/RequestEndAccessObjectImpl.java	5 Aug 2008 21:25:45 -0000	1.12.6.2
+++ src/java/com/sun/enterprise/admin/monitor/callflow/RequestEndAccessObjectImpl.java	3 Nov 2008 11:24:23 -0000
@@ -94,7 +94,7 @@
             for (int i = 0 ; i<transferObject.length; i++) {
                 RequestEndTO request = (RequestEndTO)transferObject[i];
                 pstmt.setString(1, request.getRequestId());
-                pstmt.setLong(2, request.getTimeStamp());
+                pstmt.setDouble(2, utility.longToDouble(request.getTimeStamp()));
                 pstmt.addBatch();
             }
             int[] updated = pstmt.executeBatch();
Index: src/java/com/sun/enterprise/admin/monitor/callflow/RequestStartAccessObjectImpl.java
===================================================================
RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/admin/monitor/callflow/RequestStartAccessObjectImpl.java,v
retrieving revision 1.13.6.2
diff -u -r1.13.6.2 RequestStartAccessObjectImpl.java
--- src/java/com/sun/enterprise/admin/monitor/callflow/RequestStartAccessObjectImpl.java	5 Aug 2008 21:25:45 -0000	1.13.6.2
+++ src/java/com/sun/enterprise/admin/monitor/callflow/RequestStartAccessObjectImpl.java	3 Nov 2008 11:24:23 -0000
@@ -117,8 +117,8 @@
             for (int i = 0 ; i<requestStart.length; i++) {
                 RequestStartTO request = (RequestStartTO)requestStart[i];
                 pstmt.setString(1, request.getRequestId());
-                pstmt.setLong(2, request.getTimeStamp());
-                pstmt.setLong (3, request.getTimeStampMillis());
+                pstmt.setDouble(2, utility.longToDouble(request.getTimeStamp()));
+                pstmt.setDouble (3, utility.longToDouble(request.getTimeStampMillis()));
                 if(request.getRequestType() != null)
                     pstmt.setString(4, request.getRequestType().toString());
                 else
Index: src/java/com/sun/enterprise/admin/monitor/callflow/StartTimeAccessObjectImpl.java
===================================================================
RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/admin/monitor/callflow/StartTimeAccessObjectImpl.java,v
retrieving revision 1.11.6.2
diff -u -r1.11.6.2 StartTimeAccessObjectImpl.java
--- src/java/com/sun/enterprise/admin/monitor/callflow/StartTimeAccessObjectImpl.java	5 Aug 2008 21:25:45 -0000	1.11.6.2
+++ src/java/com/sun/enterprise/admin/monitor/callflow/StartTimeAccessObjectImpl.java	3 Nov 2008 11:24:23 -0000
@@ -87,7 +87,7 @@
             for (int i = 0 ; i<transferObject.length; i++) {
                 StartTimeTO startTimeTO = (StartTimeTO)transferObject[i];
                 pstmt.setString(1, startTimeTO.getRequestId());
-                pstmt.setLong(2, startTimeTO.getTimeStamp());
+                pstmt.setDouble(2, utility.longToDouble(startTimeTO.getTimeStamp()));
                 pstmt.setString(
                         3, startTimeTO.getContainerTypeOrApplicationType());
                 pstmt.addBatch();
Index: src/java/com/sun/enterprise/admin/monitor/callflow/TableInfo.java
===================================================================
RCS file: /cvs/glassfish/admin/monitor/src/java/com/sun/enterprise/admin/monitor/callflow/TableInfo.java,v
retrieving revision 1.10
diff -u -r1.10 TableInfo.java
--- src/java/com/sun/enterprise/admin/monitor/callflow/TableInfo.java	5 May 2007 05:24:18 -0000	1.10
+++ src/java/com/sun/enterprise/admin/monitor/callflow/TableInfo.java	3 Nov 2008 11:24:24 -0000
@@ -53,7 +53,7 @@
     public static final String REQUEST_ID_TYPE = " VARCHAR(255) ";
 
     public static final String TIME_STAMP = "TIME_STAMP";
-    public static final String TIME_STAMP_TYPE = " BIGINT ";
+    public static final String TIME_STAMP_TYPE = " DOUBLE ";
 
     //<editor-fold defaultstate="collapsed" desc="SQL Statements Keywords">    
     /**
@@ -95,7 +95,7 @@
     
     public static final String TIME_STAMP_MILLIS = "TIME_STAMP_MILLIS";
     
-    public static final String TIME_STAMP_MILLIS_TYPE = " BIGINT ";
+    public static final String TIME_STAMP_MILLIS_TYPE = " DOUBLE ";
     
     public static final String IP_ADDRESS = "IP_ADDRESS";
     public static final String IP_ADDRESS_TYPE = " VARCHAR (15) ";

Files Modified:
? build
? changes.txt
? filestouched.txt
? src/java/com/sun/enterprise/admin/monitor/callflow/utility.java
M src/java/com/sun/enterprise/admin/monitor/callflow/DbAccessObjectImpl.java
M src/java/com/sun/enterprise/admin/monitor/callflow/MethodEndAccessObjectImpl.java
M src/java/com/sun/enterprise/admin/monitor/callflow/MethodStartAccessObjectImpl.java
M src/java/com/sun/enterprise/admin/monitor/callflow/RequestEndAccessObjectImpl.java
M src/java/com/sun/enterprise/admin/monitor/callflow/RequestStartAccessObjectImpl.java
M src/java/com/sun/enterprise/admin/monitor/callflow/StartTimeAccessObjectImpl.java
M src/java/com/sun/enterprise/admin/monitor/callflow/TableInfo.java